linux-kernel - Re: [PATCH] nvme-rdma: add missing \n to end of dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1474926791.3078.9.camel@linux.intel.com>
Date:   Mon, 26 Sep 2016 14:53:11 -0700
From:   J Freyensee <james_p_freyensee@...ux.intel.com>
To:     Colin King <colin.king@...onical.com>, trivial@...nel.org,
        Keith Busch <keith.busch@...el.com>, Jens Axboe <axboe@...com>,
        linux-nvme@...ts.infradead.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nvme-rdma: add missing \n to end of dev_err message

On Sun, 2016-09-25 at 15:01 -0700, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Trival fix, dev_err message is missing a \n, so add it. Also
> break line as it was over 80 chars wide.
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Reviewed-by: Jay Freyensee <james_p_freyensee@...ux.intel.com>

> ---
>  drivers/nvme/host/rdma.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/nvme/host/rdma.c b/drivers/nvme/host/rdma.c
> index 69e1fb7..3f32995 100644
> --- a/drivers/nvme/host/rdma.c
> +++ b/drivers/nvme/host/rdma.c
> @@ -1227,7 +1227,8 @@ static int nvme_rdma_conn_rejected(struct
> nvme_rdma_queue *queue,
>  			(struct nvme_rdma_cm_rej *)ev-
> >param.conn.private_data;
>  
>  		dev_err(queue->ctrl->ctrl.device,
> -			"Connect rejected, status %d.",
> le16_to_cpu(rej->sts));
> +			"Connect rejected, status %d.\n",
> +			le16_to_cpu(rej->sts));
>  		/* XXX: Think of something clever to do here... */
>  	} else {
>  		dev_err(queue->ctrl->ctrl.device,