linux-kernel - Re: [PATCH 1/2] fbdev: ssd1307fb: constify the device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 27 Sep 2016 11:42:06 +0300
From:   Tomi Valkeinen <tomi.valkeinen@...com>
To:     LABBE Corentin <clabbe.montjoie@...il.com>
CC:     <linux-fbdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] fbdev: ssd1307fb: constify the device_info pointer

On 16/08/16 12:27, LABBE Corentin wrote:
> of_match_device return const data, so instead of casting its return value
> this patch constify the device_info pointer.
> 
> Signed-off-by: LABBE Corentin <clabbe.montjoie@...il.com>
> ---
>  drivers/video/fbdev/ssd1307fb.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c
> index a9c45c8..b6c9ecf 100644
> --- a/drivers/video/fbdev/ssd1307fb.c
> +++ b/drivers/video/fbdev/ssd1307fb.c
> @@ -64,7 +64,7 @@ struct ssd1307fb_par {
>  	u32 contrast;
>  	u32 dclk_div;
>  	u32 dclk_frq;
> -	struct ssd1307fb_deviceinfo *device_info;
> +	const struct ssd1307fb_deviceinfo *device_info;
>  	struct i2c_client *client;
>  	u32 height;
>  	struct fb_info *info;
> @@ -559,8 +559,8 @@ static int ssd1307fb_probe(struct i2c_client *client,
>  	par->info = info;
>  	par->client = client;
>  
> -	par->device_info = (struct ssd1307fb_deviceinfo *)of_match_device(
> -			ssd1307fb_of_match, &client->dev)->data;
> +	par->device_info = of_match_device(ssd1307fb_of_match,
> +					   &client->dev)->data;
>  
>  	par->reset = of_get_named_gpio(client->dev.of_node,
>  					 "reset-gpios", 0);
> 

Thanks, queued these for 4.9.

 Tomi



Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)