linux-kernel - Re: [PATCH] greybus: manifest: style fix missing space before '('

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKohpom-C0XjiNPhKGetX9iY_ik5t8No+=ehvnyPP2vDJkR1qQ@mail.gmail.com>
Date:   Tue, 27 Sep 2016 15:06:19 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Quentin Lambert <lambert.quentin@...il.com>
Cc:     Johan Hovold <johan@...nel.org>, Alex Elder <elder@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "open list:ANDROID DRIVERS" <devel@...verdev.osuosl.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] greybus: manifest: style fix missing space before '('

On 27 September 2016 at 15:03, Quentin Lambert
<lambert.quentin@...il.com> wrote:
>
>
> On 27/09/2016 11:31, Viresh Kumar wrote:
>>
>> On Tue, Sep 27, 2016 at 2:50 PM, Quentin Lambert
>> <lambert.quentin@...il.com> wrote:
>>>
>>> Checkpatch printed a style ERROR concerning a missing space befire '('.
>>> This patch fix this issue.
>>>
>>> Signed-off-by: Quentin Lambert <lambert.quentin@...il.com>
>>> ---
>>>   drivers/staging/greybus/manifest.c |    2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> --- a/drivers/staging/greybus/manifest.c
>>> +++ b/drivers/staging/greybus/manifest.c
>>> @@ -11,7 +11,7 @@
>>>
>>>   static const char *get_descriptor_type_string(u8 type)
>>>   {
>>> -       switch(type) {
>>> +       switch (type) {
>>>          case GREYBUS_TYPE_INVALID:
>>>                  return "invalid";
>>>          case GREYBUS_TYPE_STRING:
>>
>> Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
>
> Wow I just noticed the typo: "befire" do you want me to resend ?

Oops, sorry for missing that.

Yes, please resend the patch as V2 and feel free to add my Ack to it.

--
viresh