linux-kernel - Re: [PATCH] greybus: manifest: style fix missing space before '('

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160927094738.GX13620@mwanda>
Date:   Tue, 27 Sep 2016 12:47:38 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Quentin Lambert <lambert.quentin@...il.com>
Cc:     Viresh Kumar <viresh.kumar@...aro.org>, devel@...verdev.osuosl.org,
        Alex Elder <elder@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        kernel-janitors@...r.kernel.org, Johan Hovold <johan@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] greybus: manifest: style fix missing space before '('

On Tue, Sep 27, 2016 at 11:33:49AM +0200, Quentin Lambert wrote:
> 
> 
> On 27/09/2016 11:31, Viresh Kumar wrote:
> >On Tue, Sep 27, 2016 at 2:50 PM, Quentin Lambert
> ><lambert.quentin@...il.com> wrote:
> >>Checkpatch printed a style ERROR concerning a missing space befire '('.
> >>This patch fix this issue.
> >>
> >>Signed-off-by: Quentin Lambert <lambert.quentin@...il.com>
> >>---
> >>  drivers/staging/greybus/manifest.c |    2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >>--- a/drivers/staging/greybus/manifest.c
> >>+++ b/drivers/staging/greybus/manifest.c
> >>@@ -11,7 +11,7 @@
> >>
> >>  static const char *get_descriptor_type_string(u8 type)
> >>  {
> >>-       switch(type) {
> >>+       switch (type) {
> >>         case GREYBUS_TYPE_INVALID:
> >>                 return "invalid";
> >>         case GREYBUS_TYPE_STRING:
> >Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
> Wow I just noticed the typo: "befire" do you want me to resend ?

No one cares about tiny typos in the patch description, but resend if
you want.

regards,
dan carpenter