linux-kernel - Re: [PATCH] ARM: at91: pm: remove useless extern definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cfbb320a-4fc1-4e00-5ceb-632bf0a3da67@atmel.com>
Date:   Tue, 27 Sep 2016 13:58:10 +0200
From:   Nicolas Ferre <nicolas.ferre@...el.com>
To:     Alexandre Belloni <alexandre.belloni@...e-electrons.com>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, Wenyou Yang <wenyou.yang@...el.com>
Subject: Re: [PATCH] ARM: at91: pm: remove useless extern definition

Le 27/09/2016 à 12:37, Alexandre Belloni a écrit :
> at91_ramc_base is local to pm.c, remove its definition in pm.h
> 
> Signed-off-by: Alexandre Belloni <alexandre.belloni@...e-electrons.com>
Acked-by: Nicolas Ferre <nicolas.ferre@...el.com>
> ---
>  arch/arm/mach-at91/pm.c | 2 +-
>  arch/arm/mach-at91/pm.h | 2 --
>  2 files changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c
> index b4332b727e9c..3d89b7905bd9 100644
> --- a/arch/arm/mach-at91/pm.c
> +++ b/arch/arm/mach-at91/pm.c
> @@ -55,7 +55,7 @@ static struct {
>  	int memctrl;
>  } at91_pm_data;
>  
> -void __iomem *at91_ramc_base[2];
> +static void __iomem *at91_ramc_base[2];
>  
>  static int at91_pm_valid_state(suspend_state_t state)
>  {
> diff --git a/arch/arm/mach-at91/pm.h b/arch/arm/mach-at91/pm.h
> index 3fcf8810f14e..bf980c6ef294 100644
> --- a/arch/arm/mach-at91/pm.h
> +++ b/arch/arm/mach-at91/pm.h
> @@ -18,8 +18,6 @@
>  #include <soc/at91/at91sam9_sdramc.h>
>  
>  #ifndef __ASSEMBLY__
> -extern void __iomem *at91_ramc_base[];
> -
>  #define at91_ramc_read(id, field) \
>  	__raw_readl(at91_ramc_base[id] + field)
>  
> 


-- 
Nicolas Ferre