[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a46631c4-a25f-88b7-9ab5-5e6733c63f51@oracle.com>
Date: Tue, 27 Sep 2016 09:51:40 -0500
From: Babu Moger <babu.moger@...cle.com>
To: Peter Zijlstra <peterz@...radead.org>,
Sam Ravnborg <sam@...nborg.org>
Cc: mingo@...hat.com, akpm@...ux-foundation.org, keescook@...omium.org,
dan.j.williams@...el.com, aryabinin@...tuozzo.com, tj@...nel.org,
linux-kernel@...r.kernel.org, sparclinux@...r.kernel.org
Subject: Re: [PATCH v2 1/2] config: Add new CONFIG_PROVE_LOCKING_SMALL
On 9/27/2016 6:40 AM, Peter Zijlstra wrote:
> On Tue, Sep 27, 2016 at 06:46:25AM +0200, Sam Ravnborg wrote:
>> Since this is only relevant for sparc, and for sparc this is "select"ed,
>> then there is limited/no gain having this as a visible menu config option.
>>
>> How about adding just a simple non-visible config symbol:
>>
>> config PROVE_LOCKING_SMALL
>> bool
>>
>> The nice help text can be added to the H file, and the select
>> can be move to the sparc/Kconfig file where it really belongs.
> Yes, this should not be user selectable. I don't mind the help being
> here though.
How about this?
Moved everything to arch/sparc/Kconfig.debug. It may be not useful to
have help in
config file as it is not visible. Lets have some explanation in .h file.
I will send v3 version if you all agree.
=====================================
diff --git a/arch/sparc/Kconfig.debug b/arch/sparc/Kconfig.debug
index 6db35fb..67e58a1 100644
--- a/arch/sparc/Kconfig.debug
+++ b/arch/sparc/Kconfig.debug
@@ -21,4 +21,9 @@ config FRAME_POINTER
depends on MCOUNT
default y
+config PROVE_LOCKING_SMALL
+ bool
+ depends on PROVE_LOCKING && SPARC
+ default y
+
endmenu
Powered by blists - more mailing lists