linux-kernel - Re: [PATCH 0/2 v3] cpu hotplug: Preserve topology directory after soft remove event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57EA8F96.6030303@redhat.com>
Date:   Tue, 27 Sep 2016 11:26:14 -0400
From:   Prarit Bhargava <prarit@...hat.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     Borislav Petkov <bp@...e.de>, linux-kernel@...r.kernel.org,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        Peter Zijlstra <peterz@...radead.org>,
        Len Brown <len.brown@...el.com>,
        Andi Kleen <ak@...ux.intel.com>, Jiri Olsa <jolsa@...hat.com>,
        Juergen Gross <jgross@...e.com>
Subject: Re: [PATCH 0/2 v3] cpu hotplug: Preserve topology directory after
 soft remove event



On 09/27/2016 09:49 AM, Greg Kroah-Hartman wrote:
> On Tue, Sep 27, 2016 at 07:45:56AM -0400, Prarit Bhargava wrote:
>> On 09/26/2016 07:57 AM, Borislav Petkov wrote:
>>> $ echo 0 > /sys/devices/system/cpu/cpu2/online
>>
>> This results in the topology directory being destroyed.  It shouldn't be -- the
>> socket and core are still there.  If you could open up your computer you could
>> touch them.  This is similar to downing a PCI device, or removing !kernel memory
>> DIMM from a system.  The device is still physically there.
> 
> If you remove a PCI device from the system, by turning it off from the
> PCI hotplug interface, it will go away from sysfs, just like this CPU
> device is going away, no matter if you physically remove the device or
> not.
> 

While similar, the thread's device struct, link to structures, and masks in the
kernel are kept in place.  In the PCI case these links are all destroyed which
results in requiring a bus rescan to find the devcie.  The sysfs (soft) removal
of a thread has a very different outcome from PCI.

I see now that the issue is not understanding the difference between physical
and soft thread removal.  I will write that up and get back to everyone.

P.

> Thanks for validating that everything is working the same and correctly
> :)
> 
> greg k-h
>