linux-kernel - Re: [PATCH] CodingStyle: Expand IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1475004728.16606.8.camel@tiscali.nl>
Date:   Tue, 27 Sep 2016 21:32:08 +0200
From:   Paul Bolle <pebolle@...cali.nl>
To:     Bjorn Helgaas <bhelgaas@...gle.com>,
        Jonathan Corbet <corbet@....net>
Cc:     linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH] CodingStyle: Expand IS_ENABLED() documentation

On Tue, 2016-09-27 at 14:08 -0500, Bjorn Helgaas wrote:

> --- a/Documentation/CodingStyle
> +++ b/Documentation/CodingStyle

> +Because the compiler processes the block, you have to use an #ifdef instead
> +of IS_ENABLED() when code inside the block references symbols that will not
> +exist if the condition is not met.  Different CONFIG_FOO autoconf.h symbols
> +are generated for modular Kconfig options than for builtin ones, so you
> +need "#if defined(CONFIG_FOO) || defined(CONFIG_FOO_MODULE)"

Isn't that equivalent to "#if IS_ENABLED(CONFIG_FOO)"?

> if FOO can be
> +a module:
> +
> +	.config			include/generated/autoconf.h
> +	------------		----------------------------
> +	CONFIG_FOO=y		#define CONFIG_FOO 1
> +	CONFIG_FOO=m		#define CONFIG_FOO_MODULE 1


Paul Bolle