linux-kernel - Re: [PATCH 2/3] DT: EVM: add LEDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 27 Sep 2016 22:10:35 +0200
From:   "H. Nikolaus Schaller" <hns@...delico.com>
To:     Tony Lindgren <tony@...mide.com>
Cc:     Benoît Cousson <bcousson@...libre.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Russell King <linux@...linux.org.uk>,
        linux-omap@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, letux-kernel@...nphoenux.org
Subject: Re: [PATCH 2/3] DT: EVM: add LEDs

Hi Tony,

> Am 27.09.2016 um 21:49 schrieb Tony Lindgren <tony@...mide.com>:
> 
> * H. Nikolaus Schaller <hns@...delico.com> [160926 22:27]:
>> +		led@6 {
>> +			label = "omap5:green:led3";
>> +			gpios = <&gpio9 4 GPIO_ACTIVE_HIGH>;
>> +			linux,default-trigger = "heartbeat";
>> +			default-state = "off";
>> +		};
>> +
>> +		led@7 {
>> +			label = "omap5:green:led4";
>> +			gpios = <&gpio9 5 GPIO_ACTIVE_HIGH>;
>> +			linux,default-trigger = "heartbeat";
>> +			default-state = "off";
>> +		};
>> +
>> +		led@8 {
>> +			label = "omap5:green:led5";
>> +			gpios = <&gpio9 6 GPIO_ACTIVE_HIGH>;
>> +			linux,default-trigger = "heartbeat";
>> +			default-state = "off";
>> +		};
> 
> How about this for defaults:
> 
> - heartbeat for led3
> - cpu0 for led4
> - cpu1 for led5

Good idea. Will try.

What I don't exactly know is if these gpios based on an I2C-expander
can handle cpu activity triggers or if they are locked up if this i2c
processing triggers another cpu activity...

> 
> Or something along those lines that by default shows the
> active CPUs. Don't have a omap5-uevm near by right now so
> not sure about the ordering of the LEDs for displaying
> cpu0 and cpu1.

Will test tomorrow and if it works I can submit a v2.

BR and thanks,
Nikolaus