linux-kernel - Re: [PATCH] spmi: pmic-arb: Return an error code if sanity check fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160927221550.GB940@codeaurora.org>
Date:   Tue, 27 Sep 2016 15:15:50 -0700
From:   Stephen Boyd <sboyd@...eaurora.org>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     gregkh@...uxfoundation.org, bjorn.andersson@...ymobile.com,
        marc.zyngier@....com, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] spmi: pmic-arb: Return an error code if sanity check
 fails

On 09/26, Christophe JAILLET wrote:
> If the test 'if (channel > 5)' is true, then we will return 'err' which
> is known to be 0 at this point.
> Return -EINVAL instead.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---

Reviewed-by: Stephen Boyd <sboyd@...eaurora.org>

Looks right, thanks.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project