linux-kernel - Re: [PATCH 2/3] kvm: x86: do not use KVM_REQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <520afc01-7936-0d41-6d45-67bd88e7475b@redhat.com>
Date:   Wed, 28 Sep 2016 13:55:17 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     "Wu, Feng" <feng.wu@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>
Cc:     "yang.zhang.wz@...il.com" <yang.zhang.wz@...il.com>,
        "mst@...hat.com" <mst@...hat.com>,
        "rkrcmar@...hat.com" <rkrcmar@...hat.com>
Subject: Re: [PATCH 2/3] kvm: x86: do not use KVM_REQ_EVENT for APICv
 interrupt injection



On 28/09/2016 13:53, Wu, Feng wrote:
>> > - update_cr8_intercept is disabled if APICv, see vmx.c:
>> > 
>> >         if (enable_apicv)
>> >                 kvm_x86_ops->update_cr8_intercept = NULL;
> Which tree are you using, I am using linux kernel tree with Linux 4.8-rc7,
> and I only see the following code in vmx.c
> 
> if(!cpu_has_vmx_tpr_shadow())
> 	kvm_x86_ops->update_cr8_intercept = NULL;

You're right, it was an older tree.  On the other hand, 4.8-rc7 has this
in update_cr8_intercept:

        if (vcpu->arch.apicv_active)
                return;

:)

Paolo