lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 28 Sep 2016 13:56:06 +0200 From: Paul Bolle <pebolle@...cali.nl> To: SF Markus Elfring <elfring@...rs.sourceforge.net> Cc: gigaset307x-common@...ts.sourceforge.net, netdev@...r.kernel.org, Karsten Keil <isdn@...ux-pingi.de>, LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org, Julia Lawall <julia.lawall@...6.fr> Subject: Re: [PATCH 0/5] ISDN-Gigaset: Fine-tuning for three function implementations On Mon, 2016-09-26 at 17:37 +0200, SF Markus Elfring wrote: > Some update suggestions were taken into account > from static source code analysis. > > Markus Elfring (5): > Use kmalloc_array() in two functions > Improve another size determination in gigaset_initcs() > Delete an error message for a failed memory allocation > Release memory in gigaset_initcs() after an allocation failure > Enclose two expressions for the sizeof operator by parentheses > > drivers/isdn/gigaset/common.c | 31 ++++++++++++++++--------------- > 1 file changed, 16 insertions(+), 15 deletions(-) Two of the five patches introduced bugs. The rest of the series isn't free of various nits either. Of course, I was in no mood to be lenient when I looked at those three patches. I won't take any of these patches, sorry. Paul Bolle
Powered by blists - more mailing lists