linux-kernel - Re: [PATCH v2] Staging: android: fix permissions style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160928132638.GA26551@kroah.com>
Date:   Wed, 28 Sep 2016 15:26:38 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Ramiro Oliveira <Ramiro.Oliveira@...opsys.com>
Cc:     arve@...roid.com, riandrews@...roid.com,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        joe@...ches.com
Subject: Re: [PATCH v2] Staging: android: fix permissions style

On Wed, Sep 28, 2016 at 02:23:00PM +0100, Ramiro Oliveira wrote:
> Change permissions from symbolic to octal.
> 
> V2: Fix all the permissions, previous patch was missing some.
> Signed-off-by: Ramiro Oliveira <roliveir@...opsys.com>
> ---
>  drivers/staging/android/lowmemorykiller.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c
> index 80d7adf..553a3ee 100644
> --- a/drivers/staging/android/lowmemorykiller.c
> +++ b/drivers/staging/android/lowmemorykiller.c
> @@ -204,10 +204,10 @@ device_initcall(lowmem_init);
>   * not really modular, but the easiest way to keep compat with existing
>   * bootargs behaviour is to continue using module_param here.
>   */
> -module_param_named(cost, lowmem_shrinker.seeks, int, S_IRUGO | S_IWUSR);
> +module_param_named(cost, lowmem_shrinker.seeks, int, 0644);
>  module_param_array_named(adj, lowmem_adj, short, &lowmem_adj_size,
> -			 S_IRUGO | S_IWUSR);
> +			 0644);
>  module_param_array_named(minfree, lowmem_minfree, uint, &lowmem_minfree_size,
> -			 S_IRUGO | S_IWUSR);
> -module_param_named(debug_level, lowmem_debug_level, uint, S_IRUGO | S_IWUSR);
> +			 0644);
> +module_param_named(debug_level, lowmem_debug_level, uint, 0644);
>  

Still doesn't apply, make sure you always work against linux-next...

thanks,

greg k-h