linux-kernel - Re: [PATCH] perf tools: Fix building in 32 bit platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160928133901.GQ5588@kernel.org>
Date:   Wed, 28 Sep 2016 10:39:01 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Wang Nan <wangnan0@...wei.com>
Cc:     lizefan@...wei.com, linux-kernel@...r.kernel.org, pi3orama@....com,
        Arnaldo Carvalho de Melo <acme@...hat.com>,
        Jiri Olsa <jolsa@...nel.org>
Subject: Re: [PATCH] perf tools: Fix building in 32 bit platform

Em Wed, Sep 28, 2016 at 03:58:46AM +0000, Wang Nan escreveu:
> On ARM32 building it report following error:
> 
> util/data-convert-bt.c: In function 'add_bpf_output_values':
> util/data-convert-bt.c:440:3: error: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'unsigned int' [-Werror=format]
> cc1: all warnings being treated as errors
> 
> Fix it by changing %lu to %zu.

Thanks, applied.

- Arnaldo
 
> Signed-off-by: Wang Nan <wangnan0@...wei.com>
> Cc: Arnaldo Carvalho de Melo <acme@...hat.com>
> Cc: Jiri Olsa <jolsa@...nel.org>
> ---
>  tools/perf/util/data-convert-bt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/data-convert-bt.c b/tools/perf/util/data-convert-bt.c
> index 4f979bb..7123f4d 100644
> --- a/tools/perf/util/data-convert-bt.c
> +++ b/tools/perf/util/data-convert-bt.c
> @@ -437,7 +437,7 @@ add_bpf_output_values(struct bt_ctf_event_class *event_class,
>  	int ret;
>  
>  	if (nr_elements * sizeof(u32) != raw_size)
> -		pr_warning("Incorrect raw_size (%u) in bpf output event, skip %lu bytes\n",
> +		pr_warning("Incorrect raw_size (%u) in bpf output event, skip %zu bytes\n",
>  			   raw_size, nr_elements * sizeof(u32) - raw_size);
>  
>  	len_type = bt_ctf_event_class_get_field_by_name(event_class, "raw_len");
> -- 
> 1.8.3.4