lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 28 Sep 2016 11:38:04 -0400 From: Mike Snitzer <snitzer@...hat.com> To: SF Markus Elfring <elfring@...rs.sourceforge.net> Cc: dm-devel@...hat.com, linux-raid@...r.kernel.org, Alasdair Kergon <agk@...hat.com>, Shaohua Li <shli@...nel.org>, LKML <linux-kernel@...r.kernel.org>, kernel-janitors@...r.kernel.org, Julia Lawall <julia.lawall@...6.fr> Subject: Re: [PATCH 00/10] md/dm-crypt: Fine-tuning for five function implementations On Wed, Sep 28 2016 at 11:34am -0400, SF Markus Elfring <elfring@...rs.sourceforge.net> wrote: > From: Markus Elfring <elfring@...rs.sourceforge.net> > Date: Wed, 28 Sep 2016 17:25:17 +0200 > > Some update suggestions were taken into account > from static source code analysis. > > Markus Elfring (10): > Use kcalloc() in crypt_alloc_tfms() > Reduce the scope for a variable in crypt_alloc_tfms() > Rename a jump label in crypt_message() > Delete an unnecessary variable initialisation in crypt_message() > Rename a jump label in crypt_set_key() > Delete an unnecessary variable initialisation in crypt_set_key() > Rename a jump label in crypt_iv_tcw_whitening() > Return directly after a failed crypto_alloc_ahash() in crypt_iv_essiv_ctr() > Two checks and one function call less in crypt_iv_essiv_ctr() after error detection > Delete unnecessary variable initialisations in crypt_iv_essiv_ctr() > > drivers/md/dm-crypt.c | 51 ++++++++++++++++++++++----------------------------- > 1 file changed, 22 insertions(+), 29 deletions(-) These are _not_ the kind of changes I want to be seeing. Churn in the name of "fine-tuning". Nack.
Powered by blists - more mailing lists