linux-kernel - Re: [PATCH] Fixes: 3d44a78f0d8b ("staging: rtl8712: Remove unnecessary 'else'")

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160928061016.GA2841@kroah.com>
Date:   Wed, 28 Sep 2016 08:10:16 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Matthew Kilgore <mattkilgore12@...il.com>
Cc:     namrataashettar@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fixes: 3d44a78f0d8b ("staging: rtl8712: Remove
 unnecessary 'else'")

On Tue, Sep 27, 2016 at 11:07:54PM -0400, Matthew Kilgore wrote:
> An "unnecessary" 'else' was removed due to complains from checkpatch.pl
> as it is preceded by a 'return', however the 'else' branch is necessary
> as an earlier branch of the 'if' falls through. By removing the 'else',
> that route now hits the 'break' and the 'while' loop exits prematurely.
> 
> This commit reverts that change and puts the original 'else' back in
> place.

Ugh, good catch, sorry for missing this, my fault.

greg k-h