linux-kernel - Re: [tip:x86/platform] x86/platform/mellanox: Introduce support for Mellanox systems platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160928232512.GA7630@f23x64.localdomain>
Date:   Wed, 28 Sep 2016 16:25:12 -0700
From:   Darren Hart <dvhart@...radead.org>
To:     hpa@...or.com, vadimp@...lanox.com, linux-kernel@...r.kernel.org,
        mingo@...nel.org, tglx@...utronix.de
Cc:     linux-tip-commits@...r.kernel.org
Subject: Re: [tip:x86/platform] x86/platform/mellanox: Introduce support for
 Mellanox systems platform

On Thu, Sep 22, 2016 at 01:18:52PM -0700, tip-bot for Vadim Pasternak wrote:
> Commit-ID:  58cbbee2391ce3876e6eee80a4f2a7f025859c52
> Gitweb:     http://git.kernel.org/tip/58cbbee2391ce3876e6eee80a4f2a7f025859c52
> Author:     Vadim Pasternak <vadimp@...lanox.com>
> AuthorDate: Thu, 22 Sep 2016 21:13:42 +0000
> Committer:  Thomas Gleixner <tglx@...utronix.de>
> CommitDate: Thu, 22 Sep 2016 22:13:10 +0200
> 
> x86/platform/mellanox: Introduce support for Mellanox systems platform
> 
> Enable system support for the Mellanox Technologies platform, which
> provides support for the next Mellanox basic systems: "msx6710",
> "msx6720", "msb7700", "msn2700", "msx1410", "msn2410", "msb7800",
> "msn2740", "msn2100" and also various number of derivative systems from
> the above basic types.
> 
> The Kconfig controlling compilation of this code is: MLX_PLATFORM
> 
> Signed-off-by: Vadim Pasternak <vadimp@...lanox.com>
> Cc: jiri@...nulli.us
> Cc: gregkh@...uxfoundation.org
> Cc: platform-driver-x86@...r.kernel.org
> Cc: geert@...ux-m68k.org
> Cc: linux@...ck-us.net
> Cc: akpm@...ux-foundation.org
> Cc: mchehab@...nel.org
> Cc: davem@...emloft.net
> Cc: kvalo@...eaurora.org
> Link: http://lkml.kernel.org/r/1474578822-33805-1-git-send-email-vadimp@mellanox.com
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> 
> ---
>  MAINTAINERS                               |   6 +
>  arch/x86/Kconfig                          |  12 ++
>  arch/x86/platform/Makefile                |   1 +
>  arch/x86/platform/mellanox/Makefile       |   1 +
>  arch/x86/platform/mellanox/mlx-platform.c | 266 ++++++++++++++++++++++++++++++
>  5 files changed, 286 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index a0ce40f..2adc6ef 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -7668,6 +7668,12 @@ W:	http://www.mellanox.com
>  Q:	http://patchwork.ozlabs.org/project/netdev/list/
>  F:	drivers/net/ethernet/mellanox/mlxsw/
>  
> +MELLANOX PLATFORM DRIVER
> +M:      Vadim Pasternak <vadimp@...lanox.com>
> +L:      platform-driver-x86@...r.kernel.org
> +S:      Supported
> +F:      arch/x86/platform/mellanox/mlx-platform.c

This through me as I was trying to reconcile this series with another mellanox
platform driver from Vadim to the drivers/platform/x86 tree as this one also
came to the platform-driver-x86 mailing list.

There are no other entries in MAINTAINERS that use this list without files under
drivers/platform/x86.

Thomas, HPA, Ingo, do you also use the platform-driver-x86 mailing list for
arch/x86/platform? I had assumed this was only for drivers/platform/x86.

I can definitely understand how contributors might get confused.... I think I
may have confused myself actually :-)

My two cents too late, this driver seems like it would better placed in
drivers/platform/x86 as it isn't architectural (or SoC specific) in the same way
most of the others in arch/x86/platform are, but instead is more akin to the
end-product laptop drivers and such in drivers/platform/x86 which build platform
data from DMI strings, ACPI HIDs, etc.

If this isn't the right distinction between the two similarly named trees ...
how would you like to distinguish them? I'll volunteer to get that documented
someplace convenient to make it easier to decide what goes where.

-- 
Darren Hart
Intel Open Source Technology Center