[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20160929085405.GA8895@kroah.com>
Date: Thu, 29 Sep 2016 10:54:05 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Manish Narani <manish.narani@...inx.com>
Cc: balbi@...nel.org, k.opasiak@...sung.com, r.baldyga@...sung.com,
peter.chen@...escale.com, mnarani@...inx.com,
John.Youn@...opsys.com, eu@...ipetonello.com,
i.kotrasinsk@...sung.com, linux-usb@...r.kernel.org,
linux-kernel@...r.kernel.org, anuragku@...inx.com,
punnaia@...inx.com
Subject: Re: [LINUX PATCH] usb: gadget: Configure bulk maxburst through
module parameter in gadget zero.
On Thu, Sep 29, 2016 at 02:16:44PM +0530, Manish Narani wrote:
> This patch adds support to configure bulk maxburst through
> module parameter. This parameter can be used to modify bulk
> maxburst in case if one wants to measure peak Bulk/Isoc-IN/OUT
> performance.
Eeek, this isn't the 1990's, please don't add new module parameters :)
We have much better ways of handling configuration options for a device,
why not use them (configfs, sysfs files, etc.)?
Ugh, it looks like iso_maxburst is handled this way as well.
Felipe, why is this?
thanks,
greg k-h
Powered by blists - more mailing lists