linux-kernel - [PATCH 3.12 038/119] HID: hid-input: Add parentheses to quell gcc warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <a02b9364200829b15937dc274325c317c36ebc73.1475144721.git.jslaby@suse.cz>
Date:   Thu, 29 Sep 2016 12:24:34 +0200
From:   Jiri Slaby <jslaby@...e.cz>
To:     stable@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, James C Boyd <jcboyd.dev@...il.com>,
        Jiri Kosina <jkosina@...e.cz>, Willy Tarreau <w@....eu>,
        Jiri Slaby <jslaby@...e.cz>
Subject: [PATCH 3.12 038/119] HID: hid-input: Add parentheses to quell gcc warning

From: James C Boyd <jcboyd.dev@...il.com>

3.12-stable review patch.  If anyone has any objections, please let me know.

===============

commit 09a5c34e8d6b05663ec4c3d22b1fbd9fec89aaf9 upstream.

GCC reports a -Wlogical-not-parentheses warning here; therefore
add parentheses to shut it up and to express our intent more.

Signed-off-by: James C Boyd <jcboyd.dev@...il.com>
Signed-off-by: Jiri Kosina <jkosina@...e.cz>
Cc: Willy Tarreau <w@....eu>
Signed-off-by: Jiri Slaby <jslaby@...e.cz>
---
 drivers/hid/hid-input.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
index 8c58c820488c..5fbb46fe6ebf 100644
--- a/drivers/hid/hid-input.c
+++ b/drivers/hid/hid-input.c
@@ -1109,7 +1109,7 @@ void hidinput_hid_event(struct hid_device *hid, struct hid_field *field, struct
 		return;
 
 	/* report the usage code as scancode if the key status has changed */
-	if (usage->type == EV_KEY && !!test_bit(usage->code, input->key) != value)
+	if (usage->type == EV_KEY && (!!test_bit(usage->code, input->key)) != value)
 		input_event(input, EV_MSC, MSC_SCAN, usage->hid);
 
 	input_event(input, usage->type, usage->code, value);
-- 
2.10.0