linux-kernel - Re: [PATCH v3 3/7] i2c: bcm2835: Use dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <BB56B9B7-75EF-4674-9951-22426C3BD8BF@sperl.org>
Date:   Thu, 29 Sep 2016 13:05:01 +0200
From:   Martin Sperl <martin@...rl.org>
To:     Noralf Trønnes <noralf@...nnes.org>
Cc:     wsa@...-dreams.de, Stephen Warren <swarren@...dotorg.org>,
        Eric Anholt <eric@...olt.net>,
        linux-rpi-kernel <linux-rpi-kernel@...ts.infradead.org>,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-i2c@...r.kernel.org
Subject: Re: [PATCH v3 3/7] i2c: bcm2835: Use dev_dbg logging on transfer errors

On 28.09.2016, at 19:50, Noralf Trønnes <noralf@...nnes.org> wrote:
> 
> Writing to an AT24C32 generates on average 2x i2c transfer errors per
> 32-byte page write. Which amounts to a lot for a 4k write. This is due
> to the fact that the chip doesn't respond during it's internal write
> cycle when the at24 driver tries and retries the next write.
> Only a handful drivers use dev_err() on transfer error, so switch to
> dev_dbg() instead.
> 
> Signed-off-by: Noralf Trønnes <noralf@...nnes.org>
Reviewed-by: Martin Sperl <kernel@...tin.sperl.org>