linux-kernel - Re: [PATCH] pci: remove error message when device not present

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3286868.r1zjOMuMhU@vostro.rjw.lan>
Date:   Thu, 29 Sep 2016 14:34:40 +0200
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Grant Likely <grant.likely@...retlab.ca>
Cc:     linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
        Grant Likely <grant.likely@....com>,
        Linn Crosetto <linn@....com>,
        Bjorn Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH] pci: remove error message when device not present

On Thursday, September 29, 2016 12:28:43 PM Grant Likely wrote:
> It's not an error if the IBM ACPI pseudo-device isn't present, it merely
> means the kernel isn't running on that IBM hardware. Get rid of the
> error report so as not to pollute the kernel log with an message
> irrelevant to the vast majority of users.
> 
> If someone wants to debug it, they can turn on the pr_debug() message
> which will show progress through the .init function.
> 
> Reported-by: Jim Hull <jim.hull@....com>
> Signed-off-by: Grant Likely <grant.likely@....com>
> Cc: Linn Crosetto <linn@....com>
> Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>
> Cc: Bjorn Helgaas <bhelgaas@...gle.com>

ACK

> ---
>  drivers/pci/hotplug/acpiphp_ibm.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/pci/hotplug/acpiphp_ibm.c b/drivers/pci/hotplug/acpiphp_ibm.c
> index f6221d7..ec43510 100644
> --- a/drivers/pci/hotplug/acpiphp_ibm.c
> +++ b/drivers/pci/hotplug/acpiphp_ibm.c
> @@ -439,7 +439,6 @@ static int __init ibm_acpiphp_init(void)
>  	if (acpi_walk_namespace(ACPI_TYPE_DEVICE, ACPI_ROOT_OBJECT,
>  			ACPI_UINT32_MAX, ibm_find_acpi_device, NULL,
>  			&ibm_acpi_handle, NULL) != FOUND_APCI) {
> -		pr_err("%s: acpi_walk_namespace failed\n", __func__);
>  		retval = -ENODEV;
>  		goto init_return;
>  	}
> 

Thanks,
Rafael