linux-kernel - Re: [PATCH 2/6] ipr: use pci_irq_allocate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160929153237.GA32512@lst.de>
Date:   Thu, 29 Sep 2016 17:32:37 +0200
From:   Christoph Hellwig <hch@....de>
To:     Brian King <brking@...ux.vnet.ibm.com>
Cc:     Christoph Hellwig <hch@....de>, hans.verkuil@...co.com,
        brking@...ibm.com, haver@...ux.vnet.ibm.com,
        ching2048@...ca.com.tw, axboe@...com, alex.williamson@...hat.com,
        kvm@...r.kernel.org, linux-scsi@...r.kernel.org,
        linux-block@...r.kernel.org, linux-media@...r.kernel.org,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/6] ipr: use pci_irq_allocate_vectors

On Thu, Sep 29, 2016 at 09:01:44AM -0500, Brian King wrote:
> Thanks Christoph. Very nice. As I was reviewing the patch, I noticed
> the additional PCI_IRQ_AFFINITY flag, which is currently not being set
> in this patch. Is the intention to set that globally by default, or
> should I follow up with a one liner to add that to the ipr driver
> in the next patch set I send out?

Hi Brian,

PCI_IRQ_AFFINITY seems useful for ipr, especially if you also increase
the number of vectors above the current default 2.  And yes, please
make it a separate patch.