linux-kernel - RE: [PATCH] dma/fsldma : Unmap region obtained by of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM2PR04MB077041DAFE156C77017972E68FCE0@AM2PR04MB0770.eurprd04.prod.outlook.com>
Date:   Thu, 29 Sep 2016 16:57:38 +0000
From:   Leo Li <leoyang.li@....com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>,
        "leoli@...escale.com" <leoli@...escale.com>,
        "vinod.koul@...el.com" <vinod.koul@...el.com>
CC:     "dan.j.williams@...el.com" <dan.j.williams@...el.com>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] dma/fsldma : Unmap region obtained by of_iomap



> -----Original Message-----
> From: Arvind Yadav [mailto:arvind.yadav.cs@...il.com]
> Sent: Wednesday, September 28, 2016 5:45 AM
> To: leoli@...escale.com; zw@...kernel.org; vinod.koul@...el.com
> Cc: dan.j.williams@...el.com; linuxppc-dev@...ts.ozlabs.org;
> dmaengine@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH] dma/fsldma : Unmap region obtained by of_iomap
> 
> Free memory mapping, if probe is not successful.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

Acked-by: Li Yang <leoyang.li@....com>

> ---
>  drivers/dma/fsldma.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c index
> 911b717..7ba8944 100644
> --- a/drivers/dma/fsldma.c
> +++ b/drivers/dma/fsldma.c
> @@ -1351,7 +1351,7 @@ static int fsldma_of_probe(struct platform_device
> *op)
>  	if (!fdev->regs) {
>  		dev_err(&op->dev, "unable to ioremap registers\n");
>  		err = -ENOMEM;
> -		goto out_free_fdev;
> +		goto out_free;
>  	}
> 
>  	/* map the channel IRQ if it exists, but don't hookup the handler yet */
> @@ -1416,6 +1416,8 @@ static int fsldma_of_probe(struct platform_device
> *op)
> 
>  out_free_fdev:
>  	irq_dispose_mapping(fdev->irq);
> +	iounmap(fdev->regs);
> +out_free:
>  	kfree(fdev);
>  out_return:
>  	return err;
> --
> 1.7.9.5