[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CANk1AXTbKhiSu3XN4HgTM_rBBQ315qseH06RzojOOZrV74M7yQ@mail.gmail.com>
Date: Wed, 28 Sep 2016 23:34:51 -0500
From: Alan Tull <delicious.quinoa@...il.com>
To: Moritz Fischer <moritz.fischer@...us.com>
Cc: Alan Tull <atull@...nsource.altera.com>,
Rob Herring <robh+dt@...nel.org>,
Frank Rowand <frowand.list@...il.com>,
Mark Rutland <mark.rutland@....com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Ian Campbell <ijc+devicetree@...lion.org.uk>,
Jon Masters <jcm@...hat.com>,
Walter Goossens <waltergoossens@...e.nl>,
Michal Simek <michal.simek@...inx.com>,
Cyril Chemparathy <cyril.chemparathy@...inx.com>,
Josh Cartwright <joshc@...com>,
Matthew Gerlach <mgerlach@...nsource.altera.com>,
Dinh Nguyen <dinguyen@...nsource.altera.com>,
Devicetree List <devicetree@...r.kernel.org>,
linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v19 05/12] fpga-mgr: add fpga image information struct
On Wed, Sep 28, 2016 at 6:41 PM, Moritz Fischer
<moritz.fischer@...us.com> wrote:
Hi Moritz,
> Hi Alan,
>
> generally ok with the change.
Cool!
>
> On Wed, Sep 28, 2016 at 11:21 AM, Alan Tull <atull@...nsource.altera.com> wrote:
>
>> -int fpga_mgr_buf_load(struct fpga_manager *mgr, u32 flags, const char *buf,
>> - size_t count)
>> +int fpga_mgr_buf_load(struct fpga_manager *mgr, struct fpga_image_info *info,
>> + const char *buf, size_t count)
>
> Doesn't this break the both socfpga and zynq if [6/12] and [7/12] are
> not part of this commit?
> i.e shouldn't 5,6 and 7 be a single commit?
Yeah, squashing those would improve bisectability.
Alan
aka atull
>
> Cheers,
> Moritz
Powered by blists - more mailing lists