linux-kernel - [tip:x86/urgent] x86/vdso: Fix building on big endian host

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-e4aad64597d7a2455a541f904365b48d607916db@git.kernel.org>
Date:   Fri, 30 Sep 2016 03:44:03 -0700
From:   tip-bot for Segher Boessenkool <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     luto@...nel.org, paul.gortmaker@...driver.com,
        linux-kernel@...r.kernel.org, mingo@...nel.org, hpa@...or.com,
        sfr@...b.auug.org.au, tglx@...utronix.de,
        segher@...nel.crashing.org
Subject: [tip:x86/urgent] x86/vdso: Fix building on big endian host

Commit-ID:  e4aad64597d7a2455a541f904365b48d607916db
Gitweb:     http://git.kernel.org/tip/e4aad64597d7a2455a541f904365b48d607916db
Author:     Segher Boessenkool <segher@...nel.crashing.org>
AuthorDate: Thu, 29 Sep 2016 11:51:00 +0000
Committer:  Thomas Gleixner <tglx@...utronix.de>
CommitDate: Fri, 30 Sep 2016 12:37:40 +0200

x86/vdso: Fix building on big endian host

We need to call GET_LE to read hdr->e_type.

Fixes: 57f90c3dfc75 ("x86/vdso: Error out if the vDSO isn't a valid DSO")
Reported-by: Paul Gortmaker <paul.gortmaker@...driver.com>
Signed-off-by: Segher Boessenkool <segher@...nel.crashing.org>
Acked-by: Andy Lutomirski <luto@...nel.org>
Cc: Stephen Rothwell <sfr@...b.auug.org.au>
Cc: linux-next@...r.kernel.org
Link: http://lkml.kernel.org/r/20160929193442.GA16617@gate.crashing.org
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>

---
 arch/x86/entry/vdso/vdso2c.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/entry/vdso/vdso2c.h b/arch/x86/entry/vdso/vdso2c.h
index 4f74119..3dab75f 100644
--- a/arch/x86/entry/vdso/vdso2c.h
+++ b/arch/x86/entry/vdso/vdso2c.h
@@ -22,7 +22,7 @@ static void BITSFUNC(go)(void *raw_addr, size_t raw_len,
 
 	ELF(Phdr) *pt = (ELF(Phdr) *)(raw_addr + GET_LE(&hdr->e_phoff));
 
-	if (hdr->e_type != ET_DYN)
+	if (GET_LE(&hdr->e_type) != ET_DYN)
 		fail("input is not a shared object\n");
 
 	/* Walk the segment table. */