linux-kernel - Re: [PATCH 2/2] net: hns: add missing function declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201609301632.24678.arnd@arndb.de>
Date:   Fri, 30 Sep 2016 16:32:24 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Baoyou Xie <baoyou.xie@...aro.org>
Cc:     yisen.zhuang@...wei.com, salil.mehta@...wei.com,
        davem@...emloft.net, huangdaode@...ilicon.com,
        lisheng011@...wei.com, xieqianqian@...wei.com, fabf@...net.be,
        oulijun@...wei.com, vinod.koul@...el.com, lipeng321@...wei.com,
        andrew@...n.ch, tremyfr@...il.com, chenny.xu@...wei.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        xie.baoyou@....com.cn, han.fei@....com.cn, tang.qiang007@....com.cn
Subject: Re: [PATCH 2/2] net: hns: add missing function declaration

On Friday 30 September 2016, Baoyou Xie wrote:
> We get 1 warning when building kernel with W=1:
> drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c:2784:5: warning: no previous prototype for 'hns_dsaf_roce_reset' [-Wmissing-prototypes]
> 
> In fact, this function is not declared in any file, but should be
> declared in a header file. thus can be recognized in other file.
> 
> so this patch adds the missing function declaration into
> drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.h.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>

If you get to a case like this, please describe in the changelog how you determined that
the function is there intentionally, rather than something that should be removed?

I also see that you had sent the patch series for hns previously, and had included
a 'v2' version in the subject, but left out the version this time. Please always
use increasing version numbers when you send a new version of the series.

	Arnd