linux-kernel - Re: [PATCH 2/2] megaraid_sas: clean function declarations in megaraid_sas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201609301634.34846.arnd@arndb.de>
Date:   Fri, 30 Sep 2016 16:34:34 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Baoyou Xie <baoyou.xie@...aro.org>
Cc:     kashyap.desai@...gotech.com, sumit.saxena@...gotech.com,
        uday.lingala@...gotech.com, jejb@...ux.vnet.ibm.com,
        martin.petersen@...cle.com, megaraidlinux.pdl@...gotech.com,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        xie.baoyou@....com.cn, han.fei@....com.cn, tang.qiang007@....com.cn
Subject: Re: [PATCH 2/2] megaraid_sas: clean function declarations in megaraid_sas_fusion.c up

On Friday 30 September 2016, Baoyou Xie wrote:
>  int megasas_transition_to_ready(struct megasas_instance *instance, int ocr);
> -void megaraid_sas_kill_hba(struct megasas_instance *instance);
>  
>  extern u32 megasas_dbg_lvl;
> -void megasas_sriov_heartbeat_handler(unsigned long instance_addr);
> -int megasas_sriov_start_heartbeat(struct megasas_instance *instance,
> -                                 int initial);
> -void megasas_start_timer(struct megasas_instance *instance,
> -                       struct timer_list *timer,
> -                        void *fn, unsigned long interval);
>  extern struct megasas_mgmt_info megasas_mgmt_info;
>  extern unsigned int resetwaittime;
>  extern unsigned int dual_qdepth_disable;

I think you should remove all "extern" declarations from the .c file at the same
time here, and move them to an appropriate header, or remove them in case the symbol
is already gone and we only have the declaration left.

	Arnd