linux-kernel - Re: [PATCH V2 2/2] fs/super.c: don't fool lockdep in freeze_super() and thaw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160930171434.GA2373@redhat.com>
Date:   Fri, 30 Sep 2016 19:14:34 +0200
From:   Oleg Nesterov <oleg@...hat.com>
To:     Jan Kara <jack@...e.cz>
Cc:     Al Viro <viro@...iv.linux.org.uk>,
        Dave Chinner <david@...morbit.com>,
        Nikolay Borisov <kernel@...p.com>,
        "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 2/2] fs/super.c: don't fool lockdep in freeze_super()
 and thaw_super() paths

On 09/27, Oleg Nesterov wrote:
>
> On 09/27, Jan Kara wrote:
> >
> > You can run either:
> >
> > 	./check -g freeze
>
> passed all 6 tests.
>
> > to check just the freezing tests or
> >
> > 	./check
> >
> > to run all sensible tests which is what I'd do (but it will take couple of
> > hours to pass). If that passes, chances are good there are no easy false
> > positives.
>
> It seems that generic/001 just hangs on my laptop. With or without this change.
> Or perhaps I didn't wait enough...

/usr/bin/awk spins in user-mode forever, according to strace it doesn't do
any syscalls. I didn't even try to investigate.

> Or perhaps something is wrong with my very
> limited testing environment. I'll reserve a testing machine tomorrow.

Jan, I gave up.

Whatever I did xfstests-dev/check reports a lot of failures, kernel bugs,
and finally either crashes the kernel or hangs.

With or without this change, and I didn't notice any warning from lockdep.
So I hope we can apply this patch. At least 1/2 which fixes a bug.

Oleg.