linux-kernel - RE: [PATCH] hv: do not lose pending heartbeat vmbus packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BN3PR03MB2227CF6EB9346430F3996548CEC10@BN3PR03MB2227.namprd03.prod.outlook.com>
Date:   Fri, 30 Sep 2016 18:31:37 +0000
From:   Long Li <longli@...rosoft.com>
To:     Vitaly Kuznetsov <vkuznets@...hat.com>,
        KY Srinivasan <kys@...rosoft.com>
CC:     Haiyang Zhang <haiyangz@...rosoft.com>,
        "devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] hv: do not lose pending heartbeat vmbus packets



> -----Original Message-----
> From: Vitaly Kuznetsov [mailto:vkuznets@...hat.com]
> Sent: Thursday, September 29, 2016 2:22 AM
> To: KY Srinivasan <kys@...rosoft.com>; Long Li <longli@...rosoft.com>
> Cc: Haiyang Zhang <haiyangz@...rosoft.com>;
> devel@...uxdriverproject.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH] hv: do not lose pending heartbeat vmbus packets
> 
> Long Li <longli@...hange.microsoft.com> writes:
> 
> > From: Long Li <longli@...rosoft.com>
> >
> > The host keeps sending heartbeat packets independent of guest
> responding to them. In some situations, there might be multiple heartbeat
> packets pending in the ring buffer. Don't lose them, read them all.
> >
> > Signed-off-by: Long Li <longli@...rosoft.com>
> 
> Long, K. Y.,
> 
> it seems this patch didn't make it to char-misc tree and it looks like an
> important fix. A couple of nitpicks below,
> 
> > ---
> >  drivers/hv/hv_util.c | 10 +++++++---
> >  1 file changed, 7 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/hv/hv_util.c b/drivers/hv/hv_util.c index
> > d5acaa2..9dc6372 100644
> > --- a/drivers/hv/hv_util.c
> > +++ b/drivers/hv/hv_util.c
> > @@ -283,10 +283,14 @@ static void heartbeat_onchannelcallback(void
> *context)
> >  	u8 *hbeat_txf_buf = util_heartbeat.recv_buffer;
> >  	struct icmsg_negotiate *negop = NULL;
> >
> > -	vmbus_recvpacket(channel, hbeat_txf_buf,
> > -			 PAGE_SIZE, &recvlen, &requestid);
> > +	while (1) {
> > +
> > +		vmbus_recvpacket(channel, hbeat_txf_buf,
> > +				 PAGE_SIZE, &recvlen, &requestid);
> 
> We should check vmbus_recvpacket() return value as well. E.g.
> hv_ringbuffer_read() may return -EAGAIN in case we didn't receive the
> whole packet (and we do this check in other drivers, see
> storvsc_on_channel_callback() for example).

I agree with you,  we should check for -EAGAIN. This should also be done in storvsc_on_channel_callback.

I think the chance of  hv_ringbuffer_read() returning -EAGAIN is almost zero. Because read_index and write_index are updated after the whole packet is written to the ring buffer, and protected by memory barriers. So getting a partial read is impossible, unless the host is doing something wrong.

Checking for recvlen is safe, because it's always set to 0 at the beginning of hv_ringbuffer_read().

Anyway, we should check for -EAGAIN for all hyperv drivers on read. I think this is a separate issue on how we deal with a buggy host. Will send another set of patches .

> 
> > +
> > +		if (!recvlen)
> 
> so this should be 'if (ret || !recvlen)'
> 
> > +			break;
> >
> > -	if (recvlen > 0) {
> >  		icmsghdrp = (struct icmsg_hdr *)&hbeat_txf_buf[
> >  				sizeof(struct vmbuspipe_hdr)];
> 
> --
>   Vitaly