linux-kernel - Re: [PATCH] include/linux/property.h: fix typo/compile error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aa6a6ed6-345f-8505-368f-6447f699493f@intel.com>
Date:   Fri, 30 Sep 2016 02:21:03 +0200
From:   "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>
To:     John Youn <johnyoun@...opsys.com>
Cc:     linux-kernel@...r.kernel.org, Hanjun Guo <hanjun.guo@...aro.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        "Suthikulpanit, Suravee" <Suravee.Suthikulpanit@....com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Subject: Re: [PATCH] include/linux/property.h: fix typo/compile error

On 9/29/2016 4:10 AM, John Youn wrote:
> This fixes commit d76eebfa175e ("include/linux/property.h: fix build
> issues with gcc-4.4.4").
>
> With that commit we get the following compile error when using the
> PROPERTY_ENTRY_INTEGER_ARRAY macro.
>
> ../include/linux/property.h:201:39: error: ‘u32_data’ undeclared (first
>                   use in this function)
>    PROPERTY_ENTRY_INTEGER_ARRAY(_name_, u32, _val_)
>                                         ^
> ../include/linux/property.h:193:17: note: in definition of macro
>                   ‘PROPERTY_ENTRY_INTEGER_ARRAY’
>    { .pointer = { _type_##_data = _val_ } },  \
>                   ^
>
> This needs a '.' to reference the union member. It seems this was just
> overlooked here since it is done correctly in similar constructs in
> other parts of the original commit.
>
> This fix is in preparation of upcoming commits that will use this macro.
>
> Fixes: commit d76eebfa175e ("include/linux/property.h: fix build issues with gcc-4.4.4")
> Signed-off-by: John Youn <johnyoun@...opsys.com>

Applied.

Thanks,
Rafael


> ---
>   include/linux/property.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/property.h b/include/linux/property.h
> index 3a2f9ae..856e50b 100644
> --- a/include/linux/property.h
> +++ b/include/linux/property.h
> @@ -190,7 +190,7 @@ struct property_entry {
>   	.length = ARRAY_SIZE(_val_) * sizeof(_type_),		\
>   	.is_array = true,					\
>   	.is_string = false,					\
> -	{ .pointer = { _type_##_data = _val_ } },		\
> +	{ .pointer = { ._type_##_data = _val_ } },		\
>   }
>   
>   #define PROPERTY_ENTRY_U8_ARRAY(_name_, _val_)			\