linux-kernel - Re: [RFC PATCH v3 2/2] usb: typec: Type-C Port Controller Interface driver (tcpci)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABXOdTc=EmFsvmTSze70TcOmSrzKGJSM+ZjyMJKqqa7RwAwRnQ@mail.gmail.com>
Date:   Sat, 1 Oct 2016 09:27:32 -0700
From:   Guenter Roeck <groeck@...gle.com>
To:     Jun Li <jun.li@....com>
Cc:     Guenter Roeck <groeck@...omium.org>,
        Felipe Balbi <felipe.balbi@...ux.intel.com>,
        Chandra Sekhar Anagani <chandra.sekhar.anagani@...el.com>,
        Bruce Ashfield <bruce.ashfield@...driver.com>,
        Bin Gao <bin.gao@...el.com>,
        Pranav Tipnis <pranav.tipnis@...el.com>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>
Subject: Re: [RFC PATCH v3 2/2] usb: typec: Type-C Port Controller Interface
 driver (tcpci)

On Fri, Sep 30, 2016 at 5:12 PM, Jun Li <jun.li@....com> wrote:
[ ... ]
>>
>> >> +     err = devm_request_threaded_irq(tcpci->dev, client->irq, NULL,
>> >> +                                     tcpci_irq,
>> >> + IRQF_TRIGGER_FALLING,
>> >
>> > IRQF_ONESHOT is required, and do we need the irq trigger to be
>> > IRQF_TRIGGER_LOW?
>> >
>>
>> Good question; I don't really know. IRQF_TRIGGER_FALLING definitely seems
>> to be wrong (and I don't recall where I got it from). Not sure about
>> IRQF_TRIGGER_LOW. Can you test on real hardware, by any chance ?
>>
>
> I tested on real hardware, IRQF_TRIGGER_LOW can work fine, so I think
> the right flag should be IRQF_TRIGGER_LOW | IRQF_ONESHOT.
>
I had wondered if the trigger should be part of the devicetree file.
However, TCPCI specifies (chapter 4, bullet point 6), that "The TCPC
shall have an open drain output, active low Alert# Pin. This pin is
used to indicate a change of state, where Alert# pin is asserted when
a ny Alert Bits are set."

Given that, I agree, and I'll add IRQF_TRIGGER_LOW.

Thanks,
Guenter