linux-kernel - Re: [PATCH] Input: synaptics-rmi4 - Fix error handling in I2C transport driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <66fca804-53e3-6bae-b1af-dd3cd2187ac6@roeck-us.net>
Date:   Fri, 30 Sep 2016 20:03:29 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        Andrew Duggan <aduggan@...aptics.com>
Subject: Re: [PATCH] Input: synaptics-rmi4 - Fix error handling in I2C
 transport driver

On 09/30/2016 03:54 PM, Dmitry Torokhov wrote:
> On Thu, Sep 29, 2016 at 10:55:40AM -0700, Bjorn Andersson wrote:
>> On Wed 28 Sep 17:37 PDT 2016, Guenter Roeck wrote:
>>
>>> Instantiating the rmi4 I2C transport driver without interrupts assigned
>>> (for example using manual i2c instantiation from the command line)
>>> caused the driver to fail to load, but it does not clean up its
>>> regulator or transport device registrations. Result is a crash at a later
>>> time, for example when rebooting the system.
>>>
>>> Fixes: 946c8432aab0 ("Input: synaptics-rmi4 - support regulator supplies")
>>
>> Sorry for that.
>>
>>> Fixes: fdf51604f104 ("Input: synaptics-rmi4 - add I2C transport driver")
>>> Cc: Bjorn Andersson <bjorn.andersson@...aro.org>
>>
>> Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>
>
> Applied, thank you.
>
> It looks like we have similar issue in rmi_spi.c. Can I get another
> patch?
>

Sure.

Guenter