linux-kernel - Re: [PATCH] rxrpc: split up rxrpc_send_call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201610010540.58123.arnd@arndb.de>
Date:   Sat, 1 Oct 2016 05:40:58 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     David Howells <dhowells@...hat.com>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rxrpc: split up rxrpc_send_call_packet()

On Saturday 01 October 2016, David Howells wrote:
> commit 35510eefc29e2757c1ac46218cded2e505093fc2
> Author: David Howells <dhowells@...hat.com>
> Date:   Sat Oct 1 00:35:15 2016 +0100
> 
>     rxrpc: Split rxrpc_send_call_packet()
>     
>     Split rxrpc_send_data_packet() to separate ACK generation (which is more
>     complicated) from ABORT generation.  This simplifies the code a bit and
>     avoids the following warning:
>     
>     In file included from ../net/rxrpc/output.c:20:0:
>     net/rxrpc/output.c: In function 'rxrpc_send_call_packet':
>     net/rxrpc/ar-internal.h:1187:27: error: 'top' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>     net/rxrpc/output.c:103:24: note: 'top' was declared here
>     net/rxrpc/output.c:225:25: error: 'hard_ack' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>     
>     Reported-by: Arnd Bergmann <arnd@...db.de>
>     Signed-off-by: David Howells <dhowells@...hat.com>

Yes, good idea. We could probably share the part of the two functions that sets the
contents of the msg and pkt variables by moving it into a third function, but I'm
not sure if that actually improves readability or just reduces the number of lines.

	Arnd