linux-kernel - Re: [PATCH] staging: sm750fb: rename macro roundedDiv to rounded_div in ddk750

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161002104314.GA15142@gmail.com>
Date:   Sun, 2 Oct 2016 13:43:14 +0300
From:   Moshe Green <mgmoshes@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Sudip Mukherjee <sudipm.mukherjee@...il.com>,
        Teddy Wang <teddy.wang@...iconmotion.com>,
        linux-fbdev@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: sm750fb: rename macro roundedDiv to rounded_div
 in ddk750_chip.c

On Sun, Oct 02, 2016 at 11:47:47AM +0200, Greg KH wrote:
> On Sun, Oct 02, 2016 at 08:48:32AM +0300, Moshe Green wrote:
> > Rename CamelCased macro roundedDiv to rounded_div.
> > 
> > This issue was found by checkpatch.pl
> > 
> > Signed-off-by: Moshe Green <mgmoshes@...il.com>
> > ---
> >  drivers/staging/sm750fb/ddk750_chip.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
> > index 3a0afe1..e4efe91 100644
> > --- a/drivers/staging/sm750fb/ddk750_chip.c
> > +++ b/drivers/staging/sm750fb/ddk750_chip.c
> > @@ -7,7 +7,7 @@
> >  #include "ddk750_power.h"
> >  
> >  /* n / d + 1 / 2 = (2n + d) / 2d */
> > -#define roundedDiv(num, denom)	((2 * (num) + (denom)) / (2 * (denom)))
> > +#define rounded_div(num, denom)	((2 * (num) + (denom)) / (2 * (denom)))
> 
> Shouldn't you use the in-kernel function for this instead?

(I thought briefly of looking for an existing implementation but
then chose not to since I wanted to minimize the functional changes in my patches
for the time being. Additionally I was wary of using a different implementation for a
division operation.)

I'll submit a patch that will replace the local implemetaion of rounded
division with the in-kernel implementation (I'm assuming you're
referring to the DIV_ROUND_CLOSEST macro from include/linux/kernel.h).

Thanks
Moshe Green