linux-kernel - Re: [PATCH] Staging : fbtft: Removed "line over 80 characters" Warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 2 Oct 2016 17:15:44 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Joe Perches <joe@...ches.com>
Cc:     Harman Kalra <harman4linux@...il.com>,
        thomas.petazzoni@...e-electrons.com, noralf@...nnes.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging : fbtft: Removed "line over 80 characters"
 Warnings

On Wed, Sep 28, 2016 at 02:27:37PM -0700, Joe Perches wrote:
> On Thu, 2016-09-29 at 02:01 +0530, Harman Kalra wrote:
> > Removed "line over 80 characters" Warnings using checkpatch.pl
> []
> > diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h
> []
> > @@ -402,7 +407,9 @@ static void __exit fbtft_driver_module_exit(void)                          \
> >  #define fbtft_init_dbg(dev, format, arg...)                  \
> >  do {                                                         \
> >  	if (unlikely((dev)->platform_data &&                 \
> > -	    (((struct fbtft_platform_data *)(dev)->platform_data)->display.debug & DEBUG_DRIVER_INIT_FUNCTIONS))) \
> > +	    (((struct fbtft_platform_data *) \
> > +		(dev)->platform_data)->display.debug \
> > +		& DEBUG_DRIVER_INIT_FUNCTIONS))) \
> >  		dev_info(dev, format, ##arg);                \
> >  } while (0)
> 
> A nicer way to do might be a statement expression macro
> 
> #define fbtft_init_dbg(dev, format, ...)				\
> ({									\
> 	struct fbtft_platform_data *pdata;				\
> 	pdata = (struct fbtft_platform_data *)((dev)->platform_data);	\
> 	if (unlikely(pdata &&						\
> 		     pdata->display.debug & DEBUG_DRIVER_INIT_FUNCTIONS)) \
> 		dev_info(dev, format, ##__VA_ARGS__);
> })

Yes, that is almost readable, I like that a lot better :)

thanks,

greg k-h