linux-kernel - [PATCH] pwm: tiehrpwm: fix disabled state of pwm when inverted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <1475494622-43846-1-git-send-email-cabarnes@indesign-llc.com>
Date:   Mon, 3 Oct 2016 07:37:02 -0400
From:   Clifton Barnes <cabarnes@...esign-llc.com>
To:     <thierry.reding@...il.com>
CC:     <linux-pwm@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: [PATCH] pwm: tiehrpwm: fix disabled state of pwm when inverted

The disable function forces the output to low regardless of whether
the PWM is inverted. Fix this by checking the inverted status of the
PWM and force the output to the proper state when disabled.

Signed-off-by: Clifton Barnes <cabarnes@...esign-llc.com>
---
 drivers/pwm/pwm-tiehrpwm.c |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/pwm/pwm-tiehrpwm.c b/drivers/pwm/pwm-tiehrpwm.c
index b5c6b06..e47e020 100644
--- a/drivers/pwm/pwm-tiehrpwm.c
+++ b/drivers/pwm/pwm-tiehrpwm.c
@@ -372,13 +372,14 @@ static void ehrpwm_pwm_disable(struct pwm_chip *chip, struct pwm_device *pwm)
 {
 	struct ehrpwm_pwm_chip *pc = to_ehrpwm_pwm_chip(chip);
 	unsigned short aqcsfrc_val, aqcsfrc_mask;
+	bool inv = pc->polarity[pwm->hwpwm] == PWM_POLARITY_INVERSED;
 
-	/* Action Qualifier puts PWM output low forcefully */
+	/* Action Qualifier puts PWM output high/low forcefully */
 	if (pwm->hwpwm) {
-		aqcsfrc_val = AQCSFRC_CSFB_FRCLOW;
+		aqcsfrc_val = inv ? AQCSFRC_CSFB_FRCHIGH : AQCSFRC_CSFB_FRCLOW;
 		aqcsfrc_mask = AQCSFRC_CSFB_MASK;
 	} else {
-		aqcsfrc_val = AQCSFRC_CSFA_FRCLOW;
+		aqcsfrc_val = inv ? AQCSFRC_CSFA_FRCHIGH : AQCSFRC_CSFA_FRCLOW;
 		aqcsfrc_mask = AQCSFRC_CSFA_MASK;
 	}
 
-- 
1.7.9.5