linux-kernel - Re: [PATCH 14/15] staging: wlang-ng: fix line style warnings in prism2sta.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1475511366.24781.1.camel@perches.com>
Date:   Mon, 03 Oct 2016 09:16:06 -0700
From:   Joe Perches <joe@...ches.com>
To:     Sergio Paracuellos <sergio.paracuellos@...il.com>,
        gregkh@...uxfoundation.org
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 14/15]  staging: wlang-ng: fix line style warnings in
 prism2sta.c

On Mon, 2016-10-03 at 18:04 +0200, Sergio Paracuellos wrote:
> This patch fix the following checkpatch.pl warnings in prism2sta.c:
> WARNING: line over 80 characters
[]
> diff --git a/drivers/staging/wlan-ng/prism2sta.c b/drivers/staging/wlan-ng/prism2sta.c
[]
> @@ -1099,7 +1101,8 @@ static void prism2sta_inf_hostscanresults(struct wlandevice *wlandev,
>  
>  	kfree(hw->scanresults);
>  
> -	hw->scanresults = kmemdup(inf, sizeof(struct hfa384x_InfFrame), GFP_ATOMIC);
> +	hw->scanresults = kmemdup(inf,
> +				  sizeof(struct hfa384x_InfFrame), GFP_ATOMIC);

Perhaps better as

	hw->scanresults = kmemdup(inf, sizeof(*inf), GFP_ATOMIC);