linux-kernel - Re: [PATCH 14/15] staging: wlang-ng: fix line style warnings in prism2sta.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1475518703.24781.4.camel@perches.com>
Date:   Mon, 03 Oct 2016 11:18:23 -0700
From:   Joe Perches <joe@...ches.com>
To:     Sergio Paracuellos <sergio.paracuellos@...il.com>,
        gregkh@...uxfoundation.org
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 14/15] staging: wlang-ng: fix line style warnings in
 prism2sta.c

On Mon, 2016-10-03 at 20:12 +0200, Sergio Paracuellos wrote:
> El 2016年10月03日 a las 18:16, Joe Perches escribió:
> > Perhaps better as	hw->scanresults = kmemdup(inf, sizeof(*inf), GFP_ATOMIC);
> I agree. But because all the code is full of sizeof(struct xxx) I though 
> it would be bettter to follow the actual style and not change only one...
> I don't have any problem in fix this patch and resend it. What should I do?

I suggest not fixing this patch.

Maybe just send another patch changing all the applicable
sizeof(struct <foo>) uses to sizeof(*var) with the appropriate
line wrapping.