[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20161003210350.GB8871@codeaurora.org>
Date: Mon, 3 Oct 2016 14:03:50 -0700
From: Stephen Boyd <sboyd@...eaurora.org>
To: kgunda@...eaurora.org
Cc: Mark Brown <broonie@...nel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sudip Mukherjee <sudipm.mukherjee@...il.com>,
linux-kernel@...r.kernel.org, aghayal@....qualcomm.com,
adharmap@...eaurora.org
Subject: Re: [PATCH] spmi: regmap: enable userspace writes
On 09/30, kgunda@...eaurora.org wrote:
> On 2016-09-29 23:30, Mark Brown wrote:
> >On Thu, Sep 29, 2016 at 05:06:26PM +0530, Kiran Gunda wrote:
> >
> >>-#undef REGMAP_ALLOW_WRITE_DEBUGFS
> >>+#define REGMAP_ALLOW_WRITE_DEBUGFS
> >
> >This is completely inappropriate for upstream, if you need to do
> >debugging on your platform you can enable this locally but enabling
> >random writes from userspace to any regmap device is really not a good
> >idea for system stablity or robustness.
>
> Sure. I will remove this change and send the next version only to update
> the spmi device name.
Why? The device name looks fine.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
Powered by blists - more mailing lists