linux-kernel - Re: [PATCH] bus: qcom-ebi2: make it explicitly non-modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZ-RkHzgVgAMMtAHh3ROV5eW_ftDXUURsmP_Bw37bR9jg@mail.gmail.com>
Date:   Tue, 4 Oct 2016 00:27:01 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] bus: qcom-ebi2: make it explicitly non-modular

On Tue, Sep 27, 2016 at 3:20 AM, Paul Gortmaker
<paul.gortmaker@...driver.com> wrote:

> The Kconfig currently controlling compilation of this code is:
>
> drivers/bus/Kconfig:config QCOM_EBI2
> drivers/bus/Kconfig:    bool "Qualcomm External Bus Interface 2 (EBI2)"
>
> ...meaning that it currently is not being built as a module by anyone.
>
> Lets remove the couple traces of modular infrastructure use, so that
> when reading the driver there is no doubt it is builtin-only.
>
> Since module_platform_driver() uses the same init level priority as
> builtin_platform_driver() the init ordering remains unchanged with
> this commit.
>
> We also delete the MODULE_LICENSE tag etc. since all that information
> is already contained at the top of the file in the comments.
>
> We don't replace module.h with init.h since the file already has that.
>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>

I was asked during review to make it a module, from originally
being a bool.

Just missed to update Kconfig as it seems :(

So the right patch is a oneliner making it tristate.

Yours,
Linus Walleij