linux-kernel - Re: [PATCH 4/8] staging: rts5208: Logical continuation fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1475537148.1923.1.camel@perches.com>
Date:   Mon, 03 Oct 2016 16:25:48 -0700
From:   Joe Perches <joe@...ches.com>
To:     Wayne Porter <wporter82@...il.com>, gregkh@...uxfoundation.org
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/8] staging: rts5208: Logical continuation fixes

On Mon, 2016-10-03 at 23:17 +0000, Wayne Porter wrote:
> Checkpatch detected multiple instances of logical continuation warnings
[]
> diff --git a/drivers/staging/rts5208/xd.c b/drivers/staging/rts5208/xd.c
[]
> @@ -819,11 +819,11 @@ static int reset_xd(struct rtsx_chip *chip)
>  			}
>  
>  			if ((buf[0] == 0x01) && (buf[1] == 0x03) &&
> -			    (buf[2] == 0xD9)
> -			    && (buf[3] == 0x01) && (buf[4] == 0xFF)
> -			    && (buf[5] == 0x18) && (buf[6] == 0x02)
> -			    && (buf[7] == 0xDF) && (buf[8] == 0x01)
> -			    && (buf[9] == 0x20)) {
> +			    (buf[2] == 0xD9) &&
> +			    (buf[3] == 0x01) && (buf[4] == 0xFF) &&
> +			    (buf[5] == 0x18) && (buf[6] == 0x02) &&
> +			    (buf[7] == 0xDF) && (buf[8] == 0x01) &&
> +			    (buf[9] == 0x20)) {

memcmp might be easier to read

	if (!memcmp(buf, "\x01\x03\xd9\x01\xff\x18\x02\xdf\x01\x20", 10))