[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20161003.012426.1613500726219944583.davem@davemloft.net>
Date: Mon, 03 Oct 2016 01:24:26 -0400 (EDT)
From: David Miller <davem@...emloft.net>
To: baoyou.xie@...aro.org
Cc: nbd@...nwrt.org, blogic@...nwrt.org, matthias.bgg@...il.com,
netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
arnd@...db.de, xie.baoyou@....com.cn, han.fei@....com.cn,
tang.qiang007@....com.cn
Subject: Re: [PATCH] net: ethernet: mediatek: mark symbols static where
possible
From: Baoyou Xie <baoyou.xie@...aro.org>
Date: Fri, 30 Sep 2016 15:48:50 +0800
> We get 2 warnings when building kernel with W=1:
> drivers/net/ethernet/mediatek/mtk_eth_soc.c:2041:5: warning: no previous prototype for 'mtk_get_link_ksettings' [-Wmissing-prototypes]
> drivers/net/ethernet/mediatek/mtk_eth_soc.c:2052:5: warning: no previous prototype for 'mtk_set_link_ksettings' [-Wmissing-prototypes]
>
> In fact, these functions are only used in the file in which they are
> declared and don't need a declaration, but can be made static.
> So this patch marks these functions with 'static'.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>
Applied, thanks.
Powered by blists - more mailing lists