linux-kernel - Re: BUG_ON() in workingset_node_shadows

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1475564605.7361.11@smtp.gmail.com>
Date:   Tue, 04 Oct 2016 00:03:25 -0700
From:   Raymond Jennings <shentino@...il.com>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Johannes Weiner <hannes@...xchg.org>,
        Antonio SJ Musumeci <trapexit@...wn.link>,
        Miklos Szeredi <miklos@...redi.hu>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        stable <stable@...r.kernel.org>
Subject: Re: BUG_ON() in workingset_node_shadows_dec() triggers

On Mon, Oct 3, 2016 at 9:12 PM, Linus Torvalds 
<torvalds@...ux-foundation.org> wrote:
> On Mon, Oct 3, 2016 at 9:07 PM, Andrew Morton 
> <akpm@...ux-foundation.org> wrote:
>> 
>>  Well, it's a VM_BUG_ON and few people run with CONFIG_DEBUG_VM.
> 
> Ehh. If by "few people" you mean "pretty much everybody", you'd be
> right, but your choice of wording would be somewhat misleading,
> wouldn't you say?
> 
> Hint: here's a line from the standard Fedora kernel config:
> 
>     CONFIG_DEBUG_VM=y
> 
> so *no*. VM_BUG_ON() is no less deadly than a regular BUG_ON(). It
> just allows some people to build smaller kernels, but apparently
> distro people would rather have debugging than save a few kB of RAM.
> 
> The VM debvugging code has VM_WARN_ON() and VM_WARN_ON_ONCE() for
> people who want to get a "oops, my assumptions were wrong"
> 
> Killing machines because somebody made an assumption that was wrong 
> is not ok.
> 
> Killing the machine is ok if we have a situation where there literally
> is no other choice.

For the curious:

This would include situations like

1.  The kernel is confused and further processing would result in 
undefined behavior (like bluesmoke detecting PCC for example)

2.  Security hazards where we'd leak stuff if we don't shut down.

?

>                   Linus