linux-kernel - Re: [PATCH -resend 4/6] mdacon: enable COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6c80ac98-8034-0007-0e98-755609b78fcd@suse.cz>
Date:   Tue, 4 Oct 2016 09:09:04 +0200
From:   Jiri Slaby <jslaby@...e.cz>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Tomi Valkeinen <tomi.valkeinen@...com>,
        Linux Fbdev development list <linux-fbdev@...r.kernel.org>
Subject: Re: [PATCH -resend 4/6] mdacon: enable COMPILE_TEST build

On 10/03/2016, 11:35 AM, Geert Uytterhoeven wrote:
>> -       depends on !M68K && !PARISC && ISA
>> +       depends on !M68K && !PARISC && (ISA || COMPILE_TEST)
> 
> My first thought was
> 
>     depends on (!M68K && !PARISC && ISA) || COMPILE_TEST
> 
> but arch/m68k/include/asm/vga.h doesn't define VGA_MAP_MEM().
> Adding #include <asm-generic/vga.h> at the end of arch/m68k/include/asm/vga.h
> fixes that.
> 
> Do we want that?

The driver is not used much nowadays, so compile-testing on other
architectures is not worth it IMHO.

thanks,
-- 
js
suse labs