linux-kernel - Re: [PATCH 2/9] pinctrl: sunxi: Add bindings define

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGb2v65V2VjFujJBNRJoAvOKF5p1aE0vJOp-4NeBJHiMH8y80Q@mail.gmail.com>
Date:   Tue, 4 Oct 2016 09:57:07 +0800
From:   Chen-Yu Tsai <wens@...e.org>
To:     Maxime Ripard <maxime.ripard@...e-electrons.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Chen-Yu Tsai <wens@...e.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/9] pinctrl: sunxi: Add bindings define

On Mon, Oct 3, 2016 at 6:21 PM, Maxime Ripard
<maxime.ripard@...e-electrons.com> wrote:
> Since we have some bindings header for our hardcoded flags, let's use them
> when we can.

"Use macros from bindings header file for DT parsing"

would make the subject clearer.

Otherwise,

Acked-by: Chen-Yu Tsai <wens@...e.org>

>
> Signed-off-by: Maxime Ripard <maxime.ripard@...e-electrons.com>
> ---
>  drivers/pinctrl/sunxi/pinctrl-sunxi.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.c b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
> index 64f7f6dcc027..5be455d5e252 100644
> --- a/drivers/pinctrl/sunxi/pinctrl-sunxi.c
> +++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
> @@ -28,6 +28,8 @@
>  #include <linux/platform_device.h>
>  #include <linux/slab.h>
>
> +#include <dt-bindings/pinctrl/sun4i-a10.h>
> +
>  #include "../core.h"
>  #include "../../gpio/gpiolib.h"
>  #include "pinctrl-sunxi.h"
> @@ -164,9 +166,9 @@ static int sunxi_pctrl_parse_bias_prop(struct device_node *node)
>                 return -EINVAL;
>
>         switch (val) {
> -       case 1:
> +       case SUN4I_PINCTRL_PULL_UP:
>                 return PIN_CONFIG_BIAS_PULL_UP;
> -       case 2:
> +       case SUN4I_PINCTRL_PULL_DOWN:
>                 return PIN_CONFIG_BIAS_PULL_DOWN;
>         }
>
> --
> git-series 0.8.10