linux-kernel - Re: [PATCH 2/2] mfd: ab8500-debugfs: remove unused function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161004143942.GA29257@dell>
Date:   Tue, 4 Oct 2016 15:39:42 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Baoyou Xie <baoyou.xie@...aro.org>
Cc:     linus.walleij@...aro.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, arnd@...db.de, xie.baoyou@....com.cn
Subject: Re: [PATCH 2/2] mfd: ab8500-debugfs: remove unused function

On Sat, 24 Sep 2016, Baoyou Xie wrote:

> We get 1 warning when building kernel with W=1:
> drivers/mfd/ab8500-debugfs.c:1395:6: warning: no previous prototype for 'ab8500_dump_all_banks_to_mem' [-Wmissing-prototypes]
> 
> In fact, this function is called by no one and not exported,
> so this patch removes it.
> 
> Signed-off-by: Baoyou Xie <baoyou.xie@...aro.org>
> ---
>  drivers/mfd/ab8500-debugfs.c | 54 --------------------------------------------
>  1 file changed, 54 deletions(-)

This is already in -next:

  e310960300e78764f59a4b044205b02a5c59381a

> diff --git a/drivers/mfd/ab8500-debugfs.c b/drivers/mfd/ab8500-debugfs.c
> index 0aecd7b..9f04a25 100644
> --- a/drivers/mfd/ab8500-debugfs.c
> +++ b/drivers/mfd/ab8500-debugfs.c
> @@ -1382,60 +1382,6 @@ void ab8500_dump_all_banks(struct device *dev)
>  	}
>  }
>  
> -/* Space for 500 registers. */
> -#define DUMP_MAX_REGS 700
> -static struct ab8500_register_dump
> -{
> -	u8 bank;
> -	u8 reg;
> -	u8 value;
> -} ab8500_complete_register_dump[DUMP_MAX_REGS];
> -
> -/* This shall only be called upon kernel panic! */
> -void ab8500_dump_all_banks_to_mem(void)
> -{
> -	int i, r = 0;
> -	u8 bank;
> -	int err = 0;
> -
> -	pr_info("Saving all ABB registers for crash analysis.\n");
> -
> -	for (bank = 0; bank < AB8500_NUM_BANKS; bank++) {
> -		for (i = 0; i < debug_ranges[bank].num_ranges; i++) {
> -			u8 reg;
> -
> -			for (reg = debug_ranges[bank].range[i].first;
> -			     reg <= debug_ranges[bank].range[i].last;
> -			     reg++) {
> -				u8 value;
> -
> -				err = prcmu_abb_read(bank, reg, &value, 1);
> -
> -				if (err < 0)
> -					goto out;
> -
> -				ab8500_complete_register_dump[r].bank = bank;
> -				ab8500_complete_register_dump[r].reg = reg;
> -				ab8500_complete_register_dump[r].value = value;
> -
> -				r++;
> -
> -				if (r >= DUMP_MAX_REGS) {
> -					pr_err("%s: too many register to dump!\n",
> -						__func__);
> -					err = -EINVAL;
> -					goto out;
> -				}
> -			}
> -		}
> -	}
> -out:
> -	if (err >= 0)
> -		pr_info("Saved all ABB registers.\n");
> -	else
> -		pr_info("Failed to save all ABB registers.\n");
> -}
> -
>  static int ab8500_all_banks_open(struct inode *inode, struct file *file)
>  {
>  	struct seq_file *s;

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog