lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 3 Oct 2016 23:37:00 -0300 From: Arnaldo Carvalho de Melo <acme@...nel.org> To: Ingo Molnar <mingo@...nel.org> Cc: linux-kernel@...r.kernel.org, Linux Weekly News <lwn@....net>, Colin Ian King <colin.king@...onical.com>, Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Masami Hiramatsu <mhiramat@...nel.org>, Peter Zijlstra <peterz@...radead.org>, Ravi Bangoria <ravi.bangoria@...ux.vnet.ibm.com>, Wang Nan <wangnan0@...wei.com>, Arnaldo Carvalho de Melo <acme@...hat.com> Subject: [PATCH 01/22] perf probe: Check if *ptr2 is zero and not ptr2 From: Colin Ian King <colin.king@...onical.com> Static anaylsis with cppcheck[1] detected an incorrect comparison: [tools/perf/util/probe-event.c:216]: (warning) Char literal compared with pointer 'ptr2'. Did you intend to dereference it? Dereference ptr2 for the comparison to fix this. 1: https://sourceforge.net/p/cppcheck/wiki/Home/ Signed-off-by: Colin King <colin.king@...onical.com> Cc: Alexander Shishkin <alexander.shishkin@...ux.intel.com> Cc: Masami Hiramatsu <mhiramat@...nel.org> Cc: Peter Zijlstra <peterz@...radead.org> Cc: Ravi Bangoria <ravi.bangoria@...ux.vnet.ibm.com> Cc: Wang Nan <wangnan0@...wei.com> Fixes: 35726d3a4ca9 ("perf probe: Fix to cut off incompatible chars from group name") Link: http://lkml.kernel.org/r/20161003103431.18534-1-colin.king@canonical.com Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com> --- tools/perf/util/probe-event.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c index fcfbef07b92d..d281ae2b54e8 100644 --- a/tools/perf/util/probe-event.c +++ b/tools/perf/util/probe-event.c @@ -213,7 +213,7 @@ static int convert_exec_to_group(const char *exec, char **result) goto out; } - for (ptr2 = ptr1; ptr2 != '\0'; ptr2++) { + for (ptr2 = ptr1; *ptr2 != '\0'; ptr2++) { if (!isalnum(*ptr2) && *ptr2 != '_') { *ptr2 = '\0'; break; -- 2.7.4
Powered by blists - more mailing lists