linux-kernel - [PATCH] lib: crc-itu-t: Fix polynomial comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 4 Oct 2016 12:11:32 -0500
From:   Chris Lesiak <chris.lesiak@...or.com>
To:     Jiri Kosina <trivial@...nel.org>, <linux-kernel@...r.kernel.org>
CC:     Chris Lesiak <chris.lesiak@...or.com>
Subject: [PATCH] lib: crc-itu-t: Fix polynomial comment

The hexidecimal representation (0x1021) can be a bit confusing
because the leading 1 (x^16) is not shown.

0x1021
  | ||_ x^0  (Usually known as 1)
  | |__ x^5
  |____ x^12
        x^16 (Implicit in size of CRC)

Signed-off-by: Chris Lesiak <chris.lesiak@...or.com>
---
 include/linux/crc-itu-t.h | 2 +-
 lib/crc-itu-t.c           | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/crc-itu-t.h b/include/linux/crc-itu-t.h
index a9953c7..7f89fab 100644
--- a/include/linux/crc-itu-t.h
+++ b/include/linux/crc-itu-t.h
@@ -3,7 +3,7 @@
  *
  * Implements the standard CRC ITU-T V.41:
  *   Width 16
- *   Poly  0x1021 (x^16 + x^12 + x^15 + 1)
+ *   Poly  0x1021 (x^16 + x^12 + x^5 + 1)
  *   Init  0
  *
  * This source code is licensed under the GNU General Public License,
diff --git a/lib/crc-itu-t.c b/lib/crc-itu-t.c
index b3219d0..7ff2cf9 100644
--- a/lib/crc-itu-t.c
+++ b/lib/crc-itu-t.c
@@ -9,7 +9,7 @@
 #include <linux/module.h>
 #include <linux/crc-itu-t.h>
 
-/** CRC table for the CRC ITU-T V.41 0x1021 (x^16 + x^12 + x^15 + 1) */
+/** CRC table for the CRC ITU-T V.41 0x1021 (x^16 + x^12 + x^5 + 1) */
 const u16 crc_itu_t_table[256] = {
 	0x0000, 0x1021, 0x2042, 0x3063, 0x4084, 0x50a5, 0x60c6, 0x70e7,
 	0x8108, 0x9129, 0xa14a, 0xb16b, 0xc18c, 0xd1ad, 0xe1ce, 0xf1ef,
-- 
2.5.5