linux-kernel - Re: [PATCHv2] hwmon: adm9240: handle temperature readings below 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161004221655.GA436@roeck-us.net>
Date:   Tue, 4 Oct 2016 15:16:55 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Chris Packham <chris.packham@...iedtelesis.co.nz>
Cc:     jdelvare@...e.com, linux-hwmon@...r.kernel.org,
        linux-kernel@...r.kernel.org, Michael.Wang@...iedtelesis.co.nz
Subject: Re: [PATCHv2] hwmon: adm9240: handle temperature readings below 0

On Wed, Oct 05, 2016 at 10:40:54AM +1300, Chris Packham wrote:
> Unlike the temperature thresholds the temperature data is a 9-bit signed
> value. This allows and additional 0.5 degrees of precision on the
> reading but makes handling negative values slightly harder. In order to
> have sign-extension applied correctly the 9-bit value is stored in the
> upper bits of a signed 16-bit value. When presenting this in sysfs the
> value is shifted and scaled appropriately.
> 
> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>

Applied (after removing the extra () in the data->temp assignment).

Thanks,
Guenter

> ---
> Changes in v2:
> - Simplify as per feedback from Guenter.
> - Re-word commit message.
> 
>  drivers/hwmon/adm9240.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hwmon/adm9240.c b/drivers/hwmon/adm9240.c
> index 98114ce..8d8ede8 100644
> --- a/drivers/hwmon/adm9240.c
> +++ b/drivers/hwmon/adm9240.c
> @@ -197,7 +197,7 @@ static struct adm9240_data *adm9240_update_device(struct device *dev)
>  		data->temp = ((i2c_smbus_read_byte_data(client,
>  					ADM9240_REG_TEMP) << 8) |
>  					i2c_smbus_read_byte_data(client,
> -					ADM9240_REG_TEMP_CONF)) / 128;
> +					ADM9240_REG_TEMP_CONF));
>  
>  		for (i = 0; i < 2; i++) { /* read fans */
>  			data->fan[i] = i2c_smbus_read_byte_data(client,
> @@ -263,7 +263,7 @@ static ssize_t show_temp(struct device *dev, struct device_attribute *dummy,
>  		char *buf)
>  {
>  	struct adm9240_data *data = adm9240_update_device(dev);
> -	return sprintf(buf, "%d\n", data->temp * 500); /* 9-bit value */
> +	return sprintf(buf, "%d\n", data->temp / 128 * 500); /* 9-bit value */
>  }
>  
>  static ssize_t show_max(struct device *dev, struct device_attribute *devattr,
> -- 
> 2.10.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html