linux-kernel - RE: [PATCH v5] devicetree: bindings: uart: Add new compatible string for ZynqMP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <C89496FEAE474D468F30D558A9468D9F26D2AB89@XAP-PVEXMBX01.xlnx.xilinx.com>
Date:   Wed, 5 Oct 2016 12:23:15 +0000
From:   Nava kishore Manne <nava.manne@...inx.com>
To:     Rob Herring <robh@...nel.org>
CC:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "jslaby@...e.com" <jslaby@...e.com>,
        "michal.simek@...inx.com" <michal.simek@...inx.com>,
        Soren Brinkmann <sorenb@...inx.com>,
        "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Punnaiah Choudary Kalluri <punnaia@...inx.com>
Subject: RE: [PATCH v5] devicetree: bindings: uart: Add new compatible
 string for ZynqMP

Hi Rob,

	Thanks for the review...

> > Changes for v5:
> > 		-Fixed some minor comments.
> 
> Not a useful changelog. The point of these comments is to remind the
> reviewers of what they commented on.

Ok will take care from next version onwards...

> >  Required properties:
> > -- compatible : should be "cdns,uart-r1p8", or "xlnx,xuartps"
> > +- compatible :
> > +  Use "cdns,uart-r1p8", or "xlnx,xuartps" for Zynq-7xxx SoC.
> 
> This is still not right. It was wrong before, but you are touching it so make it
> right.
> 
> OR doesn't match the dts files. It is AND and the opposite order.
> 
> xlnx,xuartps wasn't the best naming, but it's in use so we'll have to live with it
> for zynq-7xxx.
> 
> > +  Use "cdns,uart-r1p12" for Zynq Ultrascale+ MPSoC.
> 
> What I meant here was this should have something like "xlnx,mpsoc-uart"
> as the first compatible with "cdns,uart-r1p12" as the second. Not sure if
> "mpsoc" is the best name here.

You mean something like below
 Use "xlnx,xuartps" or "cdns,uart-r1p8" for Zynq-7xxx SoC.
Use "xlnx,zynqmp-uart" or " cdns,uart-r1p12" for Zynq Ultrascale+ MPSoC.

Please correct me if my understanding is wrong.

Regards,
Navakishore.